trigger rename command after refactor#197
Conversation
if renameLocation is available, automatically trigger the rename command after the code edits are applied
|
I haven't tested it yet, but looking at the code, and the TypeScript-issue that all seems to make sense to me. Looks like a good improvement. I'll check it in more detail tomorrow. Edit: tomorrow tomorrow. Was a busy day at work :) |
|
no need to hurry, take your time. |
|
Tested and works. Commit away! One comment only, and that's really orthogonal to this PR... The more I use In Visual Studio and other editors, I have direct keys for specific refactorings. Some examples: I very often know what I want, and I'd like to just get right to it without asking my editor if it's actually an option, because I can tell up front it should be. Should we add some extra |
Yes, we could. It still going to ask about which scope you want to extract the method etc, but in many cases, the operation could be carried away without confirmation. |
see microsoft/TypeScript#18351 for details. This is backward compatible if renameLocation is not present it won't do anything. To test it locally, you need to use
release-2.5branch ofTypeScript